Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): give local variable to explicit type annotation to avoid TS7043 #12495

Merged
merged 2 commits into from
Nov 30, 2023
Merged

refactor(frontend): give local variable to explicit type annotation to avoid TS7043 #12495

merged 2 commits into from
Nov 30, 2023

Conversation

KisaragiEffective
Copy link
Collaborator

What

ローカル変数に型注釈を置きました

Why

TS7043を減らすため (#3622)

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ec04c76) 78.68% compared to head (303a237) 78.68%.

Files Patch % Lines
...src/components/global/MkMisskeyFlavoredMarkdown.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #12495   +/-   ##
========================================
  Coverage    78.68%   78.68%           
========================================
  Files          951      951           
  Lines       103427   103427           
  Branches      8328     8329    +1     
========================================
+ Hits         81382    81384    +2     
+ Misses       22045    22043    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 47a10f6 into misskey-dev:develop Nov 30, 2023
15 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 30, 2023

🙏

@KisaragiEffective KisaragiEffective deleted the patch-3 branch November 30, 2023 06:44
camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
…o avoid TS7043 (misskey-dev#12495)

* refactor: give local variable to explicit type annotation to avoid TS7043

* chore: fix lint error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants